Clean up global settings

upmaru · Feb 28, 2024 · c94a69e · c94a69e
1 parent 7ad0ab5
commit c94a69e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/lib/polar/globals.ex b/lib/polar/globals.ex
@@ -37,12 +37,14 @@ defmodule Polar.Globals do
     module = Map.fetch!(@mappings, key)
 
     case module.parse(value) do
-      {:ok, params} ->
+      {:ok, params} = result ->
         value =
           Map.from_struct(params)
           |> :erlang.term_to_binary()
 
-        Repo.insert(%Setting{key: key, value: value})
+        Repo.insert!(%Setting{key: key, value: value})
+
+        result
 
       error ->
         error
@@ -53,14 +55,16 @@ defmodule Polar.Globals do
     module = Map.fetch!(@mappings, setting.key)
 
     case module.parse(value) do
-      {:ok, params} ->
+      {:ok, params} = result ->
         value =
           Map.from_struct(params)
           |> :erlang.term_to_binary()
 
         setting
         |> Setting.changeset(%{value: value})
-        |> Repo.update()
+        |> Repo.update!()
+
+        result
 
       error ->
         error

diff --git a/test/polar/globals_test.exs b/test/polar/globals_test.exs
@@ -7,8 +7,7 @@ defmodule Polar.GlobalsTest do
     test "can create basic setting" do
       {:ok, setting} = Polar.Globals.save("basic", %{versions_per_product: 3})
 
-      assert setting.key == "basic"
-      assert %{versions_per_product: 3} = :erlang.binary_to_term(setting.value)
+      assert %Basic{versions_per_product: 3} = setting
     end
   end
 
@@ -34,7 +33,7 @@ defmodule Polar.GlobalsTest do
     test "can change basic setting" do
       {:ok, setting} = Polar.Globals.save("basic", %{versions_per_product: 2})
 
-      assert %{versions_per_product: 2} = :erlang.binary_to_term(setting.value)
+      assert %Basic{versions_per_product: 2} = setting
     end
   end
 end