Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling new #277

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

naredula-jana
Copy link

This is rebased scaling feature from "scaling" branch to the latest master branch.

@naredula-jana naredula-jana mentioned this pull request Jan 14, 2019
@naredula-jana
Copy link
Author

naredula-jana commented Jan 14, 2019

This is same as PR scaling #264 , rebased on to the latest master code.

@naredula-jana
Copy link
Author

This is same as PR scaling #264 , rebased on to the latest master code.
The unit test was failing, but scaling patch as no changes related to this error, the error as below, Any idea about this?.

import cycle not allowed in test
package github.com/upmc-enterprises/elasticsearch-operator/pkg/k8sutil (test)
imports github.com/upmc-enterprises/elasticsearch-operator/pkg/k8sutil

@stevesloka
Copy link
Member

Hey @naredula-jana sounds like you've got a cycle import, where one package imports another which imports the first.

@naredula-jana
Copy link
Author

Hey @naredula-jana sounds like you've got a cycle import, where one package imports another which imports the first.

This cycle import is not related to scaling patch. This PR is same as that of PR scaling - 264 , except that it is rebased to new master.

@naredula-jana
Copy link
Author

naredula-jana commented Jan 24, 2019

Hey @naredula-jana sounds like you've got a cycle import, where one package imports another which imports the first.

This cycle import is not related to scaling patch. This PR is same as that of PR scaling - 264 , except that it is rebased to new master.

The build is sucessfull without unit test code, but the build errored if the unit test code is included, the same unit test code was sucessfull without rebase(PR-264), and also sucessfull locally. there was something change in the build or at other places with code rebase.

@naredula-jana
Copy link
Author

naredula-jana commented Jan 26, 2019

Hey @naredula-jana sounds like you've got a cycle import, where one package imports another which imports the first.

This cycle import is not related to scaling patch. This PR is same as that of PR scaling - 264 , except that it is rebased to new master.

Solved the above issue, Now the unit test is Successful.

@stevesloka stevesloka requested a review from while1eq1 February 7, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants