Support logging in to muliple AWS accounts ECR's #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awsaccount now takes a comma separated list of accounts to get credentials. This allows a user with cross account access to login to multiple ECR's.
rickard-von-essen
force-pushed
the
multi-aws-accounts
branch
from
7117aa6 to
6602ab3
Compare
|
Closes #29 |
|
+1 this will help many people |
|
Awesome! Thanks for the PR. I'm going to test real quick, then look to see what changes for the addon to minikube. I can make a PR to update the version there as well as the setup/config text. |
|
This should be backwards compatible. The only thing that I realise I didn't test is how it behave if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment variable
awsaccountnow takes a comma separated list of accounts to get credentials. This allows a user with cross account access to login to multiple ECR's.