Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/node tutorial/keygen clarification #145

Merged

Conversation

phoniks
Copy link
Contributor

@phoniks phoniks commented Mar 4, 2024

Just a bit of extra hand holding.

Newly added lines are at 58-62, 85, & 142.

Copy link
Contributor

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the clarification!

Please revert the style changes as otherwise the CI checks will fail.
You can use the .prettierrc file for formatting rules

@phoniks
Copy link
Contributor Author

phoniks commented Mar 4, 2024

Thank you for adding the clarification!

Please revert the style changes as otherwise the CI checks will fail. You can use the .prettierrc file for formatting rules

sorry about that - looks like I had some rogue settings messing things up. This should be formatted according to the project's formatting config now.

@phoniks phoniks requested a review from mirceanis March 4, 2024 17:42
Copy link
Contributor

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mirceanis mirceanis merged commit 204afea into uport-project:main Mar 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants