Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a recovering mechanism to reconnect when required #269

Merged
merged 14 commits into from
Nov 8, 2016
Merged

Add a recovering mechanism to reconnect when required #269

merged 14 commits into from
Nov 8, 2016

Conversation

xiam
Copy link
Member

@xiam xiam commented Oct 4, 2016 •
edited
Loading

This currently works for PostgreSQL only.

This WIP already works, it just needs some cleaning.

@xiam xiam changed the title Add a recovering mechanism to reconnect when required [WIP] Add a recovering mechanism to reconnect when required Oct 17, 2016
VojtechVitek
VojtechVitek reviewed Oct 26, 2016
View reviewed changes
internal/sqladapter/database.go
driver.ErrBadConn,
db.ErrNotConnected,
db.ErrTooManyClients,
db.ErrServerRefusedConnection,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for slice

@xiam xiam changed the title [WIP] Add a recovering mechanism to reconnect when required Add a recovering mechanism to reconnect when required Oct 29, 2016
VojtechVitek
VojtechVitek approved these changes Nov 4, 2016
View reviewed changes
Copy link
Member

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This feature is pure gold.

@pkieltyka
Copy link
Member

wow, amazing work Jose

@xiam xiam merged commit 13181c0 into master Nov 8, 2016
@xiam xiam deleted the issue-226 branch November 8, 2016 17:06
@xiam
Copy link
Member Author

xiam commented Nov 8, 2016

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VojtechVitek VojtechVitek VojtechVitek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiam @pkieltyka @VojtechVitek