Add CodeQL workflow for GitHub code scanning#95
Conversation
We don't maintain or care about those other branches. Signed-off-by: Patti Vacek <pattivacek@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #95 +/- ##
=======================================
Coverage 84.46% 84.46%
=======================================
Files 172 172
Lines 12284 12284
=======================================
Hits 10376 10376
Misses 1908 1908 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mike-sul
left a comment
There was a problem hiding this comment.
The CodeQL failures are mostly in the tests/test fixtures. I wonder whether we should fix it or just turn the codeql check for the tests at all.
|
I like the idea, but I think we should get all the checks green (or disable the troublesome ones) before merging. The error appears to be with setting up the build environment: |
Valid question. Typically we've been less strict about the tests, and I'm okay with that continuing to be the case.
100% agree. I haven't had time to really dig into this but I figured putting it up was better than nothing. |
See advancedtelematic/aktualizr#1830.