Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Allow module level type's __dicts__ to be saved #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 51 additions & 1 deletion dill/dill.py
Original file line number Diff line number Diff line change
@@ -280,7 +280,30 @@ def _create_typemap():
'PyBufferedReaderType': PyBufferedReaderType,
'PyBufferedWriterType': PyBufferedWriterType,
'PyTextWrapperType': PyTextWrapperType,
"TupleIterType": type(iter(())),
"ListIterType": type(iter([])),
})

if PY3:
_reverse_typemap.update({
"DictKeysType": type({}.keys()),
"DictValuesType": type({}.values()),
"DictItemsType": type({}.items()),
"StrIterType": type(iter("")),
"BytesIterType": type(iter(bytes())),
"SetIterType": type(iter(set())),
"BytearrayIterType": type(iter(bytearray())),
"DictIterKeysType": type(iter({}.keys())),
"DictIterValuesType": type(iter({}.values())),
"DictIterItemsType": type(iter({}.items())),
"ListReverseIterType": type(iter(reversed([]))),
"RangeIterType": type(iter(range(1)))
})
else:
_reverse_typemap.update({
"RangeIterType": type(iter(xrange(1)))
})

if ExitType:
_reverse_typemap['ExitType'] = ExitType
if InputType:
@@ -813,7 +836,34 @@ def save_type(pickler, obj):
#print (obj.__dict__)
#print ("%s\n%s" % (type(obj), obj.__name__))
#print ("%s\n%s" % (obj.__bases__, obj.__dict__))
StockPickler.save_global(pickler, obj)

# if the type does not have a __dict__, or it restores its own state,
# take default action
# touching anything from _frozen_importlib leads to interesting errors
if not hasattr(obj, "__dict__") or hasattr(obj, "__setstate__") \
or obj.__module__ == '_frozen_importlib':
return StockPickler.save_global(pickler, obj)
else:
state = {}
for key, item in obj.__dict__.items():
if key not in ("__init__", "__new__"):
# check if settable. In py2, some are not
try:
setattr(obj, key, item)
except (AttributeError, TypeError):
pass
else:
state[key] = item

# fix problem with cyclic reference in py2 for logging
if not PY3 and obj.__module__ + "." + obj.__name__ == "logging.Logger":
state.pop("manager", None)

# use the slotnames for state, as this works for proxies
kwargs = {"state": ({}, state)} if state else {}
pickler.save_reduce(_import_module,
(obj.__module__ + '.' + obj.__name__,),
obj=obj, **kwargs)
return

# quick sanity checking