Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce correct python tags for pure wheels from setup.py #197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
enforce correct python tags for pure wheels from setup.py
Enforce correct python tags for pure Python wheels directly from
`setup.py`.  This should be more reliable than the current approach.
While at it, switch to correct tags for each platforms -- CPython
uses "cp" (which unlike "py" is not accepted for PyPy), and PyPy can use
pure "pp" without platform specifiers (since no extensions are
installed).

Fixes #196
mgorny committed Oct 9, 2024
commit 6008b92ab778f845b8425f215e0e78d4238b7693
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[build-system]
# Further build requirements come from setup.py via the PEP 517 interface
requires = [
"packaging",
"setuptools>=42",
]
build-backend = "setuptools.build_meta"
10 changes: 10 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
@@ -221,6 +221,7 @@ def has_ext_modules(foo):

def run_setup(with_extensions=True):
extensions = []
options = {}
if with_extensions:
extensions = [
Extension(
@@ -232,6 +233,14 @@ def run_setup(with_extensions=True):
depends=glob.glob('%s/*.h' % srcdir) + ['setup.py'],
),
]
else:
import packaging.tags

tag_name = packaging.tags.interpreter_name()
tag_version = packaging.tags.interpreter_version()
options['bdist_wheel'] = {
'python_tag':tag_name+tag_version,
}
packages = find_packages(
where=pkgdir,
exclude=['ez_setup', 'examples', 'doc',],
@@ -276,6 +285,7 @@ def run_setup(with_extensions=True):
packages=packages,
package_dir={'': pkgdir},
ext_modules=extensions,
options=options,
)
# add dependencies
depend = [dill_version]