Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reusing cached Docker image #139

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fix reusing cached Docker image #139

merged 1 commit into from
Nov 21, 2023

Conversation

gamer191
Copy link
Contributor

This PR passes --build-arg BUILDKIT_INLINE_CACHE=1 to Docker
Fixes #132
Based on kleisauke/libvips-packaging@e0b8d32:

GitHub Actions has upgraded Docker to version 23, now employing
BuildKit as the default builder in place of the legacy builder:
actions/runner-images#8003
However, BuildKit doesn't include the information needed to reuse
images for caching. Use the --build-arg BUILDKIT_INLINE_CACHE=1
flag to fix this.

Thanks @bashonly for finding that commit, and @Grub4K for helping me debug my PR

@gamer191 gamer191 changed the title Update run-on-arch.sh Fix reusing cached Docker image Nov 21, 2023
@uraimo
Copy link
Owner

uraimo commented Nov 21, 2023

Thanks @gamer191, @Grub4K and @bashonly for taking the time to look into this. I agree, this is very likely going to fix it.

@uraimo uraimo merged commit 4803fad into uraimo:master Nov 21, 2023
3 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container always rebuilt
2 participants