Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Final Form PR #221

Merged
merged 47 commits into from
Aug 15, 2019
Merged
Changes from 43 commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
e273c1c
checkpoint: using why-did-you-render
shrugs Jul 30, 2019
f231080
checkpoint: test final-form on mnemonic page
shrugs Jul 30, 2019
6b3335e
chore: minor updates to comments, code re-org
shrugs Jul 31, 2019
f4fd597
feat: initial implementation of final-form on login
shrugs Jul 31, 2019
c622065
fix: clean up logic for login/ticket
shrugs Aug 5, 2019
26f6d3e
fix: rename autosaver to valueshandler
shrugs Aug 5, 2019
329f1a9
chore: form-ify inlinethtransction and netowrking keys
shrugs Aug 5, 2019
fdeb086
chore: untested: update more form components
shrugs Aug 5, 2019
21d1c95
checkpoint: 90% done with inviteemail.js
shrugs Aug 5, 2019
6526dd7
feat: finalize final-form migration
shrugs Aug 6, 2019
e82c628
fix: clean up validator logic, so fresh so clean
shrugs Aug 6, 2019
228dce8
fix: minor updates from PR self-review
shrugs Aug 6, 2019
39bc817
Merge branch 'mino' into feat/final-form
shrugs Aug 6, 2019
52de816
fix: make waitForTransactionConfirm correctly throw on unconfirmed
shrugs Aug 6, 2019
e006bf2
chore: add note about illogical warning on ActivateCode
shrugs Aug 6, 2019
e8991de
fix: implement warnings
shrugs Aug 6, 2019
bdc5c92
fix: simplify inputsigil
shrugs Aug 6, 2019
80fec93
fix: rename to formatters, auto-downcase pat fields
shrugs Aug 6, 2019
58fbcd2
fix: allow til to be deleted if it's the last character
shrugs Aug 6, 2019
c0c82dc
fix: ticket is password type
shrugs Aug 6, 2019
91176c2
fix: html5 input props updated for a11y
shrugs Aug 6, 2019
897e4e8
Merge branch 'mino' into feat/final-form
shrugs Aug 8, 2019
8587d94
fix: lessen ui-flush delay on Ticket.js to a single-frame
shrugs Aug 8, 2019
d955c27
fix: 'v is undefined' and 'cannot read .length of undefined' errors w…
shrugs Aug 8, 2019
c67a697
fix: remove autocomplete for password inputs (not respected anyway)
shrugs Aug 9, 2019
9ba9efe
deps: use a local checkout of final-form
shrugs Aug 9, 2019
20e3963
fix: final-form-set-field-data was causing a validation loop...
shrugs Aug 9, 2019
dc028a2
fix: stops validation flickering for unecessarilly async validations
shrugs Aug 9, 2019
017d832
Merge branch 'mino' into feat/final-form
shrugs Aug 9, 2019
6d2e7f9
deps: update final-form to 4.18.4 (including async-validation fix)
shrugs Aug 12, 2019
8ff3bf1
fix: use isPromise in final-form validate function for conditional check
shrugs Aug 12, 2019
fc0bf50
deps: the result of running 'npm install' updated lockfile
shrugs Aug 12, 2019
ceb0cae
fix: allow til to be deleted, but immediately add it on insert
shrugs Aug 12, 2019
95edabb
fix: only call `onValues` when validation is not paused
shrugs Aug 12, 2019
302442c
fix: minor cleanup across forms
shrugs Aug 12, 2019
aed1af0
feat: standardize onSubmit for ActivateCode, Login/Ticket & Keystore
shrugs Aug 12, 2019
bd2be65
feat: insert ticket dashes for formatting patq
shrugs Aug 12, 2019
7b9591f
fix: re-include console.error call in Keystore.js
shrugs Aug 13, 2019
d72cd54
fix: expand ensurePatFormat to cover prependSig case
shrugs Aug 13, 2019
d5c7a6f
chore: cleanup/comment ensurePatFormat function
shrugs Aug 13, 2019
c625ba5
chore: remove dangling unused variables
shrugs Aug 13, 2019
ad8630b
feat: unilateraly decide to use email@example.com as email placeholder
shrugs Aug 13, 2019
0791f78
feat: implement double-confirm when warnings exist
shrugs Aug 13, 2019
7b50505
fix: prevent 'Login Anyway' reflow in Ticket.js
shrugs Aug 13, 2019
cdb1f70
Merge branch 'mino' into feat/final-form
shrugs Aug 14, 2019
557ffe7
fix: much better logic for warning double-confirmations
shrugs Aug 14, 2019
b019e78
feat: tidy up InviteEmails.js and cover a few error edge cases
shrugs Aug 15, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 74 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -17,6 +17,7 @@
"@hot-loader/react-dom": "^16.8.6",
"@ledgerhq/hw-app-eth": "^4.61.0",
"@ledgerhq/hw-transport-u2f": "^4.61.0",
"@welldone-software/why-did-you-render": "^3.2.3",
"PaperCollateralRenderer": "github:urbit/PaperCollateralRenderer#rc-immediate",
"async-retry": "^1.2.3",
"azimuth-js": "^0.15.1",
@@ -28,6 +29,9 @@
"ethereum-blockies-base64": "^1.0.2",
"ethereumjs-tx": "^1.3.7",
"file-saver": "^2.0.0",
"final-form": "^4.18.4",
"final-form-arrays": "^3.0.1",
"final-form-set-field-data": "^1.0.2",
"folktale": "^2.3.1",
"jszip": "^3.1.5",
"keccak": "^1.4.0",
@@ -38,6 +42,8 @@
"react": "^16.8.6",
"react-app-rewire-hot-loader": "^2.0.1",
"react-dom": "^16.8.6",
"react-final-form": "^6.3.0",
"react-final-form-arrays": "^3.1.0",
"react-hot-loader": "^4.12.0",
"react-scripts": "3.0.1",
"react-teleporter": "^1.1.0",
6 changes: 4 additions & 2 deletions src/components/Accordion.js
Original file line number Diff line number Diff line change
@@ -2,11 +2,13 @@ import React from 'react';
import { Grid, AccessoryIcon } from 'indigo-react';

export default function Accordion({
className,
views,
options,
currentTab,
onTabChange,
className,

// Tab props
...rest
}) {
const Tab = views[currentTab];
@@ -37,7 +39,7 @@ export default function Accordion({
</AccessoryIcon>
</div>
</Grid.Item>
{isActive && <Grid.Item full as={Tab} />}
{isActive && <Grid.Item full as={Tab} {...rest} />}
<Grid.Divider />
</React.Fragment>
);
20 changes: 14 additions & 6 deletions src/components/Highlighted.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,21 @@
import React from 'react';
import cn from 'classnames';

export default function Highlighted({ warning = false, ...rest }) {
export default function Highlighted({
as: As = 'span',
className,
warning = false,
...rest
}) {
return (
<span
className={cn({
red3: warning,
green3: !warning,
})}
<As
className={cn(
{
red3: warning,
green3: !warning,
},
className
)}
{...rest}
/>
);
Loading