V1: Issue #800: Adding Prepare directive which runs after Before but before Action#802
Closed
johnwyles wants to merge 2 commits intourfave:masterfrom
johnwyles:feature/adding_prepare_directive
Closed
V1: Issue #800: Adding Prepare directive which runs after Before but before Action#802johnwyles wants to merge 2 commits intourfave:masterfrom johnwyles:feature/adding_prepare_directive
johnwyles wants to merge 2 commits intourfave:masterfrom
johnwyles:feature/adding_prepare_directive
Conversation
Merging from upstream urfave/cli
johnwyles
changed the title
Author
|
@meatballhat Are you able to review and merge this? Associated issues are: #793 #800 |
Member
|
Hiya! I see that you put a bunch of work into this, and I appreciate that you were so inspired 🙏 I want to mention though, that none of the maintainers acknowledged that we want this feature - so I don't think it's appropriate for this PR to be on our plates. Also relevant here (and I mention this in #800) is the fact that I don't totally understand the feature request, and without that understanding I definitely can't review a PR. |
Member
|
I'm going to close this, actually! We can talk about this change request in this issue #800 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for #800