Use SplitN for map flags to support values containing separators #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yassinebenaid
left a comment
yassinebenaid
left a comment
There was a problem hiding this comment.
Absolutely cool. Thank you @kishen-v.
Would you add a test for this case. 🙏
Signed-off-by: Kishen Viswanathan <[email protected]>
kishen-v
force-pushed
the
prevent-valsplit
branch
from
cd792e0 to
d7125f6
Compare
Contributor
Author
|
Hey @yassinebenaid, Thank you for reviewing the changes. I have added a supporting test case to validate the same. Please let me know if there are any further changes required. |
yassinebenaid
approved these changes
Jan 6, 2026
Member
yassinebenaid
left a comment
yassinebenaid
left a comment
There was a problem hiding this comment.
LGTM 🔥 🔥 🔥
Thank you @kishen-v.
Juneezee
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR addresses the issue described in #44. With the changes proposed, a string is accepted as two parts, retaining any
:that may be present in the value, thereby allowing more flexibility.Which issue(s) this PR fixes:
#44
Release Notes