ci: build and test the camoufox tier - #509
Merged
Merged
Conversation
`camoufox` is default-off in crw-renderer, crw-server and crw-cli, and no workflow passes the feature, so `cargo test --workspace` never compiles the module. Every test the tier has, including its wall and challenge classification, is invisible to the gate.
Run the camoufox step with cdp,camoufox,cloak instead of camoufox alone: the tests that pin how the camoufox and cloak tiers interact with the ladder are gated on cdp, and cloak is default-off in every crate as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
camoufoxis default-off incrw-renderer,crw-serverandcrw-cli, and no workflow passesthe feature, so
cargo test --workspacenever compiles the module. Every test the tier has,including its wall and challenge classification, is currently invisible to the gate.
Adds one step to the
checkjob:Local run on this branch:
cargo test -p crw-renderer --features camoufoxis 15 passed,0 failed.
Standalone rather than folded into a feature branch, because the gap exists today and is worth
closing whether or not any particular camoufox change lands. Relevant to the review of #507,
whose tests this is what makes CI actually run.