-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added schema tests and foundation tests #10
added schema tests and foundation tests #10
Conversation
|
||
[metersPerUnit_mix.usda](./metersPerUnit_mixed.usda) | ||
|
||
This stage sets `metersPerUnit = 100` and also sublayers `metersPerUnit_1.usda` and `metersPerUnit_10.usda` with different values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended to demonstrate a typical usage of mixed metersPerUnit (MPU), and/or to re-emphasize that USD itself won't handle any auto-scaling to reconcile divergent MPU across layer stacks? Would be great to call that out in the documentation; thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll extend the documentation. The file is mainly aimed at showing that auto-scaling doesn't happen in the current implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion in the wg meeting, we could add some documentation, or land it and add documentation subsequently. @AlexSchwank do you have an idea on how you'd like to proceed?
I suggest we leave the PR open for another week and then merge it. This gives folks some time to point out things (like the MPU comment above) where more documentation would be good and I'll add it. Afterwards people can either create their own PRs or open issues to report missing/insufficient/out-of-date documentation. |
Some more questions of the more practical nature (for people trying to build USD files for specific cases based on these samples here):
|
…for primitives, extent and transforms.
The week has elapsed, Alex has updated with initial updates from comments. I think we are in a good place to start iterating, so I'm merging. @hybridherbst perhaps open an issue on animation tests, and another on documenting with tests are working in QuickLook? |
No description provided.