Skip to content

Conversation

@barelyhuman
Copy link
Contributor

@barelyhuman barelyhuman commented Oct 24, 2025

Description

Adds a hook to abstract the setting and reading of the pane boundaries (tab request / response pane width / height

Fixes: #5665

Screen.Recording.2025-10-24.at.2.09.28.PM.mov

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Copilot AI review requested due to automatic review settings October 24, 2025 08:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a custom hook useTabPaneBoundaries to centralize the management of request and response pane dimensions (width and height) across tabs, replacing scattered dimension management logic in the RequestTabPanel component.

Key Changes:

  • Added a new updateRequestPaneTabHeight Redux action to complement the existing width update action
  • Created useTabPaneBoundaries hook that encapsulates dimension state and setters for tab panes
  • Refactored RequestTabPanel to use the new hook, removing local state management and cleanup logic

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
packages/bruno-app/src/providers/ReduxStore/slices/tabs.js Added updateRequestPaneTabHeight action to store request pane height in tab state
packages/bruno-app/src/hooks/useTabPaneBoundaries/index.js New hook providing unified interface for reading/writing pane boundaries with reset functionality
packages/bruno-app/src/components/RequestTabPanel/index.js Refactored to use the new hook, removing duplicate logic and local state for pane dimensions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@barelyhuman barelyhuman marked this pull request as draft October 24, 2025 08:29
@barelyhuman barelyhuman marked this pull request as ready for review October 24, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When switching between request tabs, scroll bar position and response window part size is lost

1 participant