Feature/cmd click on links #5927
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirag-bruno
requested review from
bijin-bruno,
helloanoop,
lohit-bruno and
naman-bruno
as code owners
chirag-bruno
changed the base branch from
main
to
feature/cmd-click-to-links-internal
…ution with the use of makeLinkAware
5 tasks
sid-bruno
reviewed
Nov 12, 2025
Collaborator
sid-bruno
left a comment
sid-bruno
left a comment
There was a problem hiding this comment.
Tiny nitpicks to be done
Comment on lines
176
to
177
| if (this.editor?._destroyLinkAware) { | ||
| this.editor?._destroyLinkAware?.(); |
Collaborator
There was a problem hiding this comment.
Either keep the ?. exec pattern or the if condition
Comment on lines
161
to
162
| if (this.editor?._destroyLinkAware) { | ||
| this.editor?._destroyLinkAware?.(); |
Collaborator
There was a problem hiding this comment.
Same as previous comment
Comment on lines
11
to
17
| function debounce(fn, delay) { | ||
| let timer; | ||
| return function (...args) { | ||
| clearTimeout(timer); | ||
| timer = setTimeout(() => fn.apply(this, args), delay); | ||
| }; | ||
| } |
Collaborator
There was a problem hiding this comment.
lodash is already a part of the package, use that instead of writing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issue #4982.
It introduces support for Cmd+Click (macOS) and Ctrl+Click (Windows/Linux) to open links directly, improving navigation and usability within the editor.
This work builds upon [@abansal21’s original contribution](#5160).
Due to merge conflicts and to ensure consistency across CodeMirror extension implementations, their approach has been slightly refined and the related tests have been updated.
References:
Contribution Checklist