Skip to content

fix: process uptime in dev tools #5961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
+25 −7
Merged

fix: process uptime in dev tools #5961

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions packages/bruno-electron/src/app/system-monitor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class SystemMonitor {
constructor() {
this.intervalId = null;
this.isMonitoring = false;
this.startTime = Date.now();
this.startTime = null;
}

start(win, intervalMs = 2000) {
Expand All @@ -13,7 +13,6 @@ class SystemMonitor {
}

this.isMonitoring = true;
this.startTime = Date.now();

// Emit initial stats
this.emitSystemStats(win);
Expand Down Expand Up @@ -45,7 +44,21 @@ class SystemMonitor {
emitSystemStats(win) {
try {
const metrics = app.getAppMetrics();
const currentTime = Date.now();
const currentTime = new Date();

if (metrics.length === 0) {
throw new Error('No metrics found');
}

if (this.startTime == null) {
let creationTime = metrics[0].creationTime;

for (const metric of metrics) {
creationTime = Math.min(creationTime, metric.creationTime);
}

this.startTime = new Date(creationTime);
}

let totalCPU = 0;
let totalMemory = 0;
Expand All @@ -62,7 +75,7 @@ class SystemMonitor {
memory: totalMemory,
pid: process.pid,
uptime: uptime,
timestamp: new Date().toISOString()
timestamp: currentTime.toISOString()
};

if (win && !win.isDestroyed()) {
Expand All @@ -71,13 +84,18 @@ class SystemMonitor {
} catch (error) {
console.error('Error getting system stats:', error);

const memory = process.memoryUsage();
const currentTime = new Date();

const uptime = !this.startTime ? 0 : (currentTime - this.startTime) / 1000;

// Fallback stats using process.memoryUsage()
const fallbackStats = {
cpu: 0,
memory: process.memoryUsage().rss,
memory: memory.rss,
pid: process.pid,
uptime: (Date.now() - this.startTime) / 1000,
timestamp: new Date().toISOString()
uptime: uptime,
timestamp: currentTime.toISOString()
};

if (win && !win.isDestroyed()) {
Expand Down
Loading