fix(builder): early return from computeTemplateAccesses
#1846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
one of our users indicated that the websiet was procesisng hte cannonfile it turns out that `computeTemplateAccesses` will use a huge amount of compute to process template accesses, even for strings that have no template usage at all. so to prevent this from being expensive, in most cases we can early return by just doing a simple string check.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
… instead clear the one that we are already using (its pretty quick/easy to do so)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one of our users indicated that the website deployer was processing the cannonfile extremely slowly.
it turns out that
computeTemplateAccesseswill use a huge amount of compute to process template accesses, even for strings that have no template usage at all. so to prevent this from being expensive, in most cases we can early return by just doing a simple string check.