Skip to content

refactor: use typed enums in BugReviewRequest - #16

Merged
sachiniyer merged 1 commit into
mainfrom
siyer/typed-review-request
Feb 13, 2026
Merged

refactor: use typed enums in BugReviewRequest#16
sachiniyer merged 1 commit into
mainfrom
siyer/typed-review-request

Conversation

@sachiniyer

Copy link
Copy Markdown
Contributor

Replace raw String fields in BugReviewRequest with BugReviewState and
BugDismissalReason enums. Update ApiClient::update_bug_review to accept
the typed values instead of &str, making the API contract type-checked
at compile time.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

sachiniyer commented Feb 13, 2026

Copy link
Copy Markdown
Contributor Author

@sachiniyer
sachiniyer force-pushed the siyer/typed-review-request branch from 9542ca6 to 6e234ea Compare February 13, 2026 05:45
@sachiniyer
sachiniyer marked this pull request as ready for review February 13, 2026 05:47
@sachiniyer
sachiniyer changed the base branch from siyer/serde-rename-all to graphite-base/16 February 13, 2026 05:52
Replace raw String fields in BugReviewRequest with BugReviewState and
BugDismissalReason enums. Update ApiClient::update_bug_review to accept
the typed values instead of &str, making the API contract type-checked
at compile time.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sachiniyer
sachiniyer force-pushed the siyer/typed-review-request branch from 6e234ea to 6f5f600 Compare February 13, 2026 05:52
@graphite-app
graphite-app Bot changed the base branch from graphite-base/16 to main February 13, 2026 05:53
@graphite-app

graphite-app Bot commented Feb 13, 2026

Copy link
Copy Markdown

Merge activity

  • Feb 13, 5:53 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Feb 13, 5:57 AM UTC: @sachiniyer merged this pull request with Graphite.

@sachiniyer
sachiniyer merged commit 48f0260 into main Feb 13, 2026
21 checks passed
@sachiniyer
sachiniyer deleted the siyer/typed-review-request branch February 13, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant