Skip to content

chore: remove simulate_old_pagination test helper and its test - #338

Merged
sachiniyer merged 1 commit into
mainfrom
detail/dead-code/chore-remove-simulate-old-pagination-test-helper-a-2fb0e7
Sep 10, 2026
Merged

chore: remove simulate_old_pagination test helper and its test#338
sachiniyer merged 1 commit into
mainfrom
detail/dead-code/chore-remove-simulate-old-pagination-test-helper-a-2fb0e7

Conversation

@detail-app

@detail-app detail-app Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Remove the test helper simulate_old_pagination and the old_pagination_drops_resolved_bugs_issue_300 test. simulate_old_pagination re-implemented the old shared-offset fetch_page_multi_status algorithm that was deleted from production in PR #301 in favor of the offset+limit/drain approach, and the test was its only consumer. Neither guarded or exercised any live production code path — the replacement new_pagination_* tests cover the current algorithm.

History


Dead Code PRs can be configured here.


Summary by cubic

Removes the simulate_old_pagination test helper and its only test, which re-implemented the deleted shared-offset pagination algorithm. The replacement new_pagination_* tests already cover the current offset+limit/drain behavior, so this dead code no longer guards any live production path.

Written for commit 15604d5. Summary will update on new commits.

Review in cubic

@detail-app
detail-app Bot requested a review from sachiniyer August 29, 2026 17:51
@aviator-app

aviator-app Bot commented Aug 29, 2026

Copy link
Copy Markdown

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

This PR has been inactive for 7 days and will be closed in 7 days if there is no activity.

@github-actions github-actions Bot added the stale label Sep 6, 2026
@sachiniyer
sachiniyer merged commit 5e8ba56 into main Sep 10, 2026
13 checks passed
@sachiniyer
sachiniyer deleted the detail/dead-code/chore-remove-simulate-old-pagination-test-helper-a-2fb0e7 branch September 10, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant