[WIP] Hugging Face Transformers integration #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is marked as WIP as the underlying Transformer’s PR should be merged before merging this one.
Hey there,
Thanks for the great work! It’s truly going to benefit the community 🤗
I’ve been working on integrating the model into Transformers: huggingface/transformers#34784
This integration will allow users to benefit from the improvements brought by the underlying features of the GenerationMixin‘s generate method and all its generation strategies, as well as the FA2 implementation, support for batch generation, torch.compile, and more. Additionally, this will increase the model’s visibility, as we are planning communications around both the Transformers and Transformers.js integrations.
If that aligns with your plans, we would greatly appreciate a review of the modeling file (/src/transformers/models/moonshine/modeling_moonshine.py) from your side.
Thanks for giving me access to the Hub org, I'll update the necessary from my own model repos:
https://huggingface.co/eustlb/moonshine-tiny
https://huggingface.co/eustlb/moonshine-base