Skip to content

Commit

Permalink
PA-26431 Fix Insrequester Timeout Data Type
Browse files Browse the repository at this point in the history
  • Loading branch information
rafet committed Apr 25, 2024
1 parent 307d596 commit 6dcc60e
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions insrequester/requester.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"github.com/slok/goresilience/circuitbreaker"
goresilienceErrors "github.com/slok/goresilience/errors"
"github.com/slok/goresilience/retry"
"github.com/slok/goresilience/timeout"
resilienceTimeout "github.com/slok/goresilience/timeout"
"net/http"
"time"
)
Expand Down Expand Up @@ -38,7 +38,7 @@ type Requester interface {
Delete(re RequestEntity) (*http.Response, error)
WithRetry(config RetryConfig) *Request
WithCircuitbreaker(config CircuitBreakerConfig) *Request
WithTimeout(timeoutSeconds int) *Request
WithTimeout(timeout time.Duration) *Request
WithHeaders(headers Headers) *Request
Load() *Request
}
Expand Down Expand Up @@ -187,14 +187,14 @@ func (r *Request) WithCircuitbreaker(config CircuitBreakerConfig) *Request {
return r
}

func (r *Request) WithTimeout(timeoutSeconds int) *Request {
if timeoutSeconds == 0 {
func (r *Request) WithTimeout(timeout time.Duration) *Request {
if timeout == 0 {
r.timeout = 30 * time.Second
} else {
r.timeout = time.Duration(timeoutSeconds) * time.Second
r.timeout = timeout
}

mw := timeout.NewMiddleware(timeout.Config{
mw := resilienceTimeout.NewMiddleware(resilienceTimeout.Config{
Timeout: r.timeout,
})
r.middlewares = append(r.middlewares, mw)
Expand Down

0 comments on commit 6dcc60e

Please sign in to comment.