SD-103813 | implementation of the SQS receive message #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezaakgun
reviewed
Apr 15, 2024
Comment on lines
+146
to
+148
| res, err := q.client.ReceiveMessage(context.Background(), input) | ||
|
|
||
| if err != nil { |
There was a problem hiding this comment.
Suggested change
| res, err := q.client.ReceiveMessage(context.Background(), input) | |
| if err != nil { | |
| res, err := q.client.ReceiveMessage(context.Background(), input) | |
| if err != nil { |
in styling-wise, we prefer handling error directly with no new line between
inssqs/inssqs.go
Outdated
| input := &awssqs.ReceiveMessageInput{ | ||
| QueueUrl: q.url, | ||
| MaxNumberOfMessages: maxMessages, | ||
| VisibilityTimeout: visibilityTimeout, |
There was a problem hiding this comment.
isn't there a validation rule that we can apply to the visibilityTimeout like we did to maxMessages ?
| @@ -61,6 +61,9 @@ if err != nil { | |||
| } | |||
| ``` | |||
|
|
|||
| ### Receiving Messages | |||
| Receive batch of messages from SQS queue using `ReceiveMessageBatch()` | |||
|
|
|||
There was a problem hiding this comment.
code example below would be nice like examples above
rafet
reviewed
Apr 16, 2024
| // - err: An error indicating any failure during the receiving process, nil if all messages were received successfully. | ||
| func (q *queue) ReceiveMessageBatch(rmi ReceiveMessageInput) (ReceiveMessageOutput, error) { | ||
| if rmi.MaxNumberOfMessages > 10 { | ||
| return ReceiveMessageOutput{}, fmt.Errorf("maxMessages should be less than or equal to 10") |
There was a problem hiding this comment.
fmt.Errorf is redundant here, formating isn't used. we can use errors.New in inssqs/errors.go
| // - rmi: ReceiveMessageInput containing the parameters for receiving messages from the SQS queue. | ||
| // | ||
| // Returns: | ||
| // - res: A pointer to ReceiveMessageOutput containing the received messages. |
| // - err: An error indicating any failure during the receiving process, nil if all messages were received successfully. | ||
| func (q *queue) ReceiveMessageBatch(rmi ReceiveMessageInput) (ReceiveMessageOutput, error) { | ||
| if rmi.MaxNumberOfMessages > 10 { | ||
| return ReceiveMessageOutput{}, fmt.Errorf("maxMessages should be less than or equal to 10") |
There was a problem hiding this comment.
Suggested change
| return ReceiveMessageOutput{}, fmt.Errorf("maxMessages should be less than or equal to 10") | |
| return ReceiveMessageOutput{}, fmt.Errorf("MaxNumberOfMessages should be less than or equal to 10") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.