SD-96364 | Madeira Madeira | Data sent by Segment is not reaching Insider #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SD-86748 - Track Event
SD-86750 update user profile action added
SD-86746 - Authentication
emreisik95
requested review from
erayakartuna,
maxis55,
z-aec,
esezerguven and
recep-insider
z-aec
approved these changes
Oct 12, 2023
|
|
||
| if (userPayload.email_as_identifier) { | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore |
There was a problem hiding this comment.
It's not a good idea to mute eslinter, but as this bug as urgent, you can proceed
There was a problem hiding this comment.
yes it is, but most mutes about types, we can not add types manually, because of that it giving this errors.
esezerguven
reviewed
Oct 12, 2023
| description: | ||
| 'When enabled, the action will send a batch request to Insider. Batches can contain up to 1000 records in a request.', | ||
| required: true, | ||
| default: false |
There was a problem hiding this comment.
can it be default true ? for partners
There was a problem hiding this comment.
can be, segment says it can be a delay a bit for batch, because of that I think partner can decide it
maxis55
approved these changes
Oct 13, 2023
esezerguven
approved these changes
Oct 13, 2023
recep-insider
approved these changes
Nov 14, 2023
SD-102706 Add x-platform-name header.
SD-98474 | [Madeira Madeira] Custom Identifier Improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A summary of your pull request, including the what change you're making and why.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.