-
Notifications
You must be signed in to change notification settings - Fork 538
Comparing changes
Open a pull request
base repository: facebook/mcrouter
base: main
head repository: useshortcut/mcrouter
compare: main
Commits on Apr 30, 2021
-
This just ignores intelliJ config files
Paul Groudas committedApr 30, 2021 Configuration menu - View commit details
-
Copy full SHA for 5c4f50e - Browse repository at this point
Copy the full SHA 5c4f50eView commit details -
- "Install_amazon-linux-2.sh" will install required build tools and development libraries. - Adds "Makefile_amazon-linux-2" to describe the required dependency compilation order. - Updates individual recipes for compiling each dependency to generally be more consistent. - Fixes all dependencies to a specific version.
Paul Groudas committedApr 30, 2021 Configuration menu - View commit details
-
Copy full SHA for 065f705 - Browse repository at this point
Copy the full SHA 065f705View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b5fa20 - Browse repository at this point
Copy the full SHA 3b5fa20View commit details -
Paul Groudas committed
Apr 30, 2021 Configuration menu - View commit details
-
Copy full SHA for f257238 - Browse repository at this point
Copy the full SHA f257238View commit details -
Paul Groudas committed
Apr 30, 2021 Configuration menu - View commit details
-
Copy full SHA for fc04355 - Browse repository at this point
Copy the full SHA fc04355View commit details -
Reset to specific tags / revisions
This just ensures that the way we manipulate the dependencies' git repositories is consistent.
Paul Groudas committedApr 30, 2021 Configuration menu - View commit details
-
Copy full SHA for c2a07bc - Browse repository at this point
Copy the full SHA c2a07bcView commit details -
make target to create archive of binary artifacts
Paul Groudas committedApr 30, 2021 Configuration menu - View commit details
-
Copy full SHA for 5779ea5 - Browse repository at this point
Copy the full SHA 5779ea5View commit details -
Set boost libdir for mcrouter build
The mcrouter configure script does not look for boost via LD_LIBRARY_PATH nor CPPFLAGS '-H' value, instead it has a dedicated cmdline option.
Paul Groudas committedApr 30, 2021 Configuration menu - View commit details
-
Copy full SHA for 588107e - Browse repository at this point
Copy the full SHA 588107eView commit details -
Fail on systems with insufficient memory.
Paul Groudas committedApr 30, 2021 Configuration menu - View commit details
-
Copy full SHA for a7f2c03 - Browse repository at this point
Copy the full SHA a7f2c03View commit details -
Paul Groudas committed
Apr 30, 2021 Configuration menu - View commit details
-
Copy full SHA for 2f33be1 - Browse repository at this point
Copy the full SHA 2f33be1View commit details -
Merge pull request #1 from clubhouse/pgroudas/amazon-linux-support
Paul Groudas authoredApr 30, 2021 Configuration menu - View commit details
-
Copy full SHA for c798225 - Browse repository at this point
Copy the full SHA c798225View commit details
Commits on May 3, 2021
-
I am unsure as to why, but the dependency expressed as "mcrouter: deps" doesn't seem to work correctly. When invoking the equivalent of "make mcrouter", I expect it to build all the transitive dependencies of "deps", but it only builds the first dependency that it determines it needs to build, and then exits with a return value of "2". I'm just reverting this to the previous style that is redundant but works correctly.
Paul Groudas committedMay 3, 2021 Configuration menu - View commit details
-
Copy full SHA for b79d697 - Browse repository at this point
Copy the full SHA b79d697View commit details -
"git clean" during checkout of dependency
This repo defines "recipes" for dependencies which are essentially build scripts. Some of the build systems used (or at least the way they are used) will cache some state between invocations, which is confusing when testing different values for things like "LDFLAGS" and "LD_LIBRARY_PATH". Specifically, the cmake based build scripts. This change ensures that when force re-running a given recipe, we do a full clean of the repo. n.b.: we are *not* cleaning the target install dir.
Paul Groudas committedMay 3, 2021 Configuration menu - View commit details
-
Copy full SHA for abbe369 - Browse repository at this point
Copy the full SHA abbe369View commit details -
This introduces "jemalloc" as a library dependency that we build from source. While this library is available from our runtime system's package respository, mcrouter would log an error at startup implying that there is a page size mis-match between the current kernel, and the system on which jemalloc was compiled. As this package available via the EPEL[1] and not Amazon Linux directly, this isn't entirely surprising. Compiling "jemalloc" is very straightforward, but getting all the dependencies to correctly link against it during their builds was a bit challenging. Ultimately I made the following changes: 1. The default value we set for *all* recipes is: LDFLAGS="-L$INSTALL_DIR/lib -ljemalloc - "-ljemalloc" means "link against the 'jemalloc'" library. - "-L$INSTALL_DIR/lib" search "$INSTALL_DIR/lib" when looking for libraries. 2. I removed redundant LDFLAGS from each recipe following the change to the default. 3. Some builds, notable those that produce binary executables (not just shared libraries), also need to include "-Wl,-rpath=$INSTALL_DIR/lib", which embeds metadata about the dynamic libraries' location into the executable. Conceptually, this doesn't make sense to me, as we are expecting users to manage their own library path, but not setting this causes the builds to fail, and I have a limited appetite for debugging and understanding these build tools. [1]: https://fedoraproject.org/wiki/EPEL
Paul Groudas committedMay 3, 2021 Configuration menu - View commit details
-
Copy full SHA for 06fc230 - Browse repository at this point
Copy the full SHA 06fc230View commit details -
Merge pull request #2 from clubhouse/pgroudas/compile-jemalloc-from-s…
…ource
Paul Groudas authoredMay 3, 2021 Configuration menu - View commit details
-
Copy full SHA for 064eaac - Browse repository at this point
Copy the full SHA 064eaacView commit details
Commits on May 17, 2021
-
Specifying the absolute path as the target to the symlink causes portability problems because when we eventually archive up the result for distribution, the absolute paths will be incorrect on the target systems.
Paul Groudas committedMay 17, 2021 Configuration menu - View commit details
-
Copy full SHA for 656dd4e - Browse repository at this point
Copy the full SHA 656dd4eView commit details -
Exclude "include/" distributable archive.
We are really only packaging the runtime dependencies, we do not need the development headers. This saves ~200mb on the target systems.
Paul Groudas committedMay 17, 2021 Configuration menu - View commit details
-
Copy full SHA for 4a245b9 - Browse repository at this point
Copy the full SHA 4a245b9View commit details
Commits on May 21, 2021
-
This streamlines the resulting archive in three ways: 1. It only includes mcrouter and mcpiper from /bin (no thrift, zfmt, etc) 2. It only includes the libraries that mcrouter and mcpiper actually link against. This removes a bunch of boost libraries from the archive. 3. It includes the dynamic libraries not only from INSTALL_DIR, but also from the host system (e.g. libssl and libz). This archive is *NOT PORTABLE* in any meaningful way, it is only meant to run on essentially the same target system, amazon linux 2.
Paul Groudas committedMay 21, 2021 Configuration menu - View commit details
-
Copy full SHA for 5fa72da - Browse repository at this point
Copy the full SHA 5fa72daView commit details
Commits on May 24, 2021
-
[mcrouter] adjust tarball construction
`tar cf "ARCHIVE_FILE" .` has a strange side effect that it includes a reference to the current dir (which given the syntax, isn't unexpected I guess), but in practice that mangles the paths in the archive to prefix them all with "./" and confounds the permissions on the target directory when you extract the archive.
Paul Groudas committedMay 24, 2021 Configuration menu - View commit details
-
Copy full SHA for a9db3dd - Browse repository at this point
Copy the full SHA a9db3ddView commit details
Commits on Sep 30, 2021
-
Configuration menu - View commit details
-
Copy full SHA for cfb5953 - Browse repository at this point
Copy the full SHA cfb5953View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb1e3df - Browse repository at this point
Copy the full SHA fb1e3dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fea264 - Browse repository at this point
Copy the full SHA 9fea264View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7716e49 - Browse repository at this point
Copy the full SHA 7716e49View commit details
Commits on Oct 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 61b3519 - Browse repository at this point
Copy the full SHA 61b3519View commit details -
Merge pull request #7 from useshortcut/mark/sc-170835/fix-mcrouter-in…
…-latest-ami-v2 Update Mcrouter to work with latest Linux Amazon 2
Configuration menu - View commit details
-
Copy full SHA for 4179985 - Browse repository at this point
Copy the full SHA 4179985View commit details
Commits on Aug 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 78038ff - Browse repository at this point
Copy the full SHA 78038ffView commit details -
Merge pull request #8 from useshortcut/francis/sc-204217/fix-mcrouter…
…-build-on-ami
Configuration menu - View commit details
-
Copy full SHA for 8658bce - Browse repository at this point
Copy the full SHA 8658bceView commit details
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.