Fix for test AcceptLanguageParserTest that is broken by a patch of 2020#81
Open
kpouer wants to merge 1 commit intousnistgov:masterfrom
Open
Fix for test AcceptLanguageParserTest that is broken by a patch of 2020#81kpouer wants to merge 1 commit intousnistgov:masterfrom
kpouer wants to merge 1 commit intousnistgov:masterfrom
Conversation
test is not working anymore since the fix of the bug usnistgov#53 in 2012 and I think it is legitimate
Author
Author
|
In fact it is related with that issue #74 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
the test tries to encode Accept-Language: ,
which is not possible anymore since the fix of bug #53
I think it is legitimate to remove that test as the new behavior is better.