Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive multiple laserscan #52

Merged
merged 5 commits into from
Oct 30, 2023
Merged

Receive multiple laserscan #52

merged 5 commits into from
Oct 30, 2023

Conversation

dom-lee
Copy link
Contributor

@dom-lee dom-lee commented Oct 29, 2023

Graph Navigation can receive multiple laserscan data.
change laser_topics in config/navigation.lua file

Copy link
Member

@joydeep-b joydeep-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change needed: print warning when using laser offset with multiple topics.

src/navigation/navigation_main.cc Outdated Show resolved Hide resolved
Copy link
Contributor Author

@dom-lee dom-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the offset and verify if the frame_id of messages from multiple topics is set to the laser_frame defined in a configuration file

@joydeep-b
Copy link
Member

@dom-lee Removing the offset entirely will break functionality on some robots like the cars and the CoBot that have single LIDAR. You could convert to a list of offsets, or read from the TF tree - but one or the other is needed.

@@ -188,6 +190,31 @@ void OdometryCallback(const nav_msgs::Odometry& msg) {
navigation_.UpdateOdometry(odom_);
}

void RetreveTransform(const std_msgs::Header& msg,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RetrieveTransform : Spelling

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified

@dom-lee
Copy link
Contributor Author

dom-lee commented Oct 30, 2023

fixed transformation order
point_cloud_[start_idx + i] = (frame_tf * (r * cache.rays[i])).head<2>();

@dom-lee dom-lee merged commit 6a37278 into master Oct 30, 2023
1 check passed
@dom-lee dom-lee deleted the domlee branch October 30, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants