dual manipulator pose goal demo #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i forgot to mention that it is related to #6 |
|
ping @RValner |
RValner
approved these changes
Sep 20, 2019
There was a problem hiding this comment.
The only thing I noticed is that you are missing the "add dependencies" in your executable targets (add_dependencies (dual_pose_goal ${catkin_EXPORTED_TARGETS}) - seems like it compiles but it's fyi that this might cause you some trouble if you integrate new features in it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is intentionally undocumented demo (not mentioned in README) for the time being. i hoping you'll only review the .cpp and CMakeLists.txt file for this pull request to merge.
the demo is undocumented because it requires a different moveit_config to be set up and i am still pondering how to incorporate it with this package.