Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specification documents for orbit propagation with time series file #111

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Add specification documents for orbit propagation with time series file #111

merged 2 commits into from
Oct 1, 2024

Conversation

fukudakazuya
Copy link
Contributor

Overview

Add specification documents for orbit propagation with time series file

Issue

  • NA

Details

NA

Validation results

NA

Scope of influence

NA

Supplement

NA

Note

  • If there are related Projects, tie them together.
  • Assignees should be set if possible.
  • Reviewers should be set if possible.
  • Set priority label if possible.

@fukudakazuya fukudakazuya added documentation Improvements or additions to documentation priority::medium priority medium labels Sep 30, 2024
@fukudakazuya fukudakazuya requested review from 200km and a team September 30, 2024 09:54
@fukudakazuya fukudakazuya self-assigned this Sep 30, 2024
@fukudakazuya fukudakazuya requested review from ogoogo, Hiro-0110, seki-hiro, suzuki-toshihir0, t-hosonuma and conjikidow and removed request for a team September 30, 2024 09:54
200km
200km reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@200km 200km left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。微修正お願いします。

Specifications/Dynamics/Spec_TimeSeriesFileOrbit.md Outdated

## 3. Results of verifications

### 1. Verification of the error of Fourth Order Runge-Kutta method (RK4)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MUST] ここの説明がおそらくコピー元のままになっています。

Specifications/Dynamics/Spec_TimeSeriesFileOrbit.md Outdated
simulation_step_s = 10
```
- `number_of_interpolation` was set to 5.
- The interpolation method was set to polynominal method.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NITS] the polynominal method

Specifications/Dynamics/Spec_TimeSeriesFileOrbit.md
- The interpolation method was set to polynominal method.

#### 3. results
<div align="center">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[WANT] 図としては、内挿していることがわかるズームアップしたものも入れた方が適切かなと思います。

@fukudakazuya
Copy link
Contributor Author

修正しました

200km
200km approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@200km 200km left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございます。マージしてください。

@fukudakazuya fukudakazuya merged commit 6da618e into develop Oct 1, 2024
1 check passed
@fukudakazuya fukudakazuya deleted the add-time-series-file-orbit-propagation branch October 1, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@200km 200km 200km approved these changes

@ogoogo ogoogo Awaiting requested review from ogoogo ogoogo was automatically assigned from ut-issl/aocs

@Hiro-0110 Hiro-0110 Awaiting requested review from Hiro-0110 Hiro-0110 was automatically assigned from ut-issl/aocs

@seki-hiro seki-hiro Awaiting requested review from seki-hiro seki-hiro was automatically assigned from ut-issl/aocs

@suzuki-toshihir0 suzuki-toshihir0 Awaiting requested review from suzuki-toshihir0 suzuki-toshihir0 was automatically assigned from ut-issl/aocs

@t-hosonuma t-hosonuma Awaiting requested review from t-hosonuma t-hosonuma was automatically assigned from ut-issl/aocs

@conjikidow conjikidow Awaiting requested review from conjikidow conjikidow was automatically assigned from ut-issl/aocs

Assignees

@fukudakazuya fukudakazuya

Labels
documentation Improvements or additions to documentation priority::medium priority medium
Projects
S2E
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fukudakazuya @200km