Astro v5#1366
Merged
jtamatsukuri merged 4 commits intomasterfrom May 31, 2025
Merged
Conversation
|
🚀 Deployed on https://deploy-preview-1366--utelecon.netlify.app |
Member
Author
|
アーッ |
Member
Author
seieric
requested changes
May 4, 2025
Member
seieric
left a comment
seieric
left a comment
There was a problem hiding this comment.
動作確認を中心にレビューしました。一部の警告は今後の課題ということで無視しました。
package.jsonとpackage-lock.jsonがconflictしているのでそこだけ修正いただきたいです。
seieric
approved these changes
May 14, 2025
seieric
requested changes
May 15, 2025
Member
seieric
left a comment
seieric
left a comment
There was a problem hiding this comment.
エラー発生時にエラーハンドラ内でエラーが発生して、原因となるエラーが正しく表示されないようです。
seieric
approved these changes
May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
一旦最小限の変更でトライしています
影響が大きそうな点
.mdxファイル内で<Fragment />が使えなくなったようです<></>を使ってください@importはdeprecatedになりました@useや@forwardをうまく使ってください@use foo.scss as *;のようにするとよいかもしれません今後別PRで修正する点
@importを使っている箇所を@useに置き換えるAstro.globを使っている箇所をコンテンツコレクションに置き換える