fix(tests): fix saved views auth rejection tests in test_saved_views.py - #2244
Closed
trivikramkalagi91-commits wants to merge 2 commits into
Closed
fix(tests): fix saved views auth rejection tests in test_saved_views.py#2244trivikramkalagi91-commits wants to merge 2 commits into
trivikramkalagi91-commits wants to merge 2 commits into
Conversation
Contributor
Author
4 tasks
Owner
|
Closing as superseded by #2193. It duplicates the saved-view authentication coverage and also carries unrelated package-lock changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix two failing test cases (
test_unauthenticated_request_rejectedandtest_wrong_api_key_rejected) intesting/backend/unit/test_saved_views.py.These tests were failing because
app_clientis pre-configured with a mock dependency override forrequire_api_keythat always returns success. This fix temporarily deletes the override from the app'sdependency_overridesdictionary during the test execution and restores it in afinallyblock, ensuring that unauthenticated and incorrect key requests are correctly rejected with a401 Unauthorizedstatus.Related Issues
Fixes test regressions introduced in PR #2051 (closes #1770 ).
Type of Change
How Has This Been Tested?
Ran the saved views unit test suite locally:
.\venv\Scripts\pytest testing/backend/unit/test_saved_views.py -vChecklist