Skip to content

fix: delay object URL cleanup after downloads - #2313

Open
HitanshiThakar wants to merge 1 commit into
utksh1:mainfrom
HitanshiThakar:fix/safari-download-object-url
Open

fix: delay object URL cleanup after downloads#2313
HitanshiThakar wants to merge 1 commit into
utksh1:mainfrom
HitanshiThakar:fix/safari-download-object-url

Conversation

@HitanshiThakar

Copy link
Copy Markdown
Collaborator

Description

Delays object URL cleanup in downloadFile to avoid revoking the URL before downloads begin in Safari.

Changes include:

  • Delay URL.revokeObjectURL(url) by 1000ms after a.click().
  • Preserve the existing download flow, including blob creation, filename handling, anchor setup, and click behavior.
  • Add a focused regression test to verify that object URL cleanup occurs after the delay.

Related Issues

Closes #1848

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran:
npm test -- exportUtils.test.ts

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

@utksh1 utksh1 added area:frontend Frontend React/UI work level:beginner 20 pts difficulty label for small beginner-friendly PRs type:bug Bug fix work category bonus label labels Jul 30, 2026 — with ChatGPT Codex Connector

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focused Safari download fix with a deterministic timer regression test. The failed run contains the pre-existing saved-views baseline failure; main now passes. Approved once the branch is refreshed against current main so required checks rerun.

@utksh1
utksh1 force-pushed the fix/safari-download-object-url branch from 7c956b1 to dae05d0 Compare August 5, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:frontend Frontend React/UI work level:beginner 20 pts difficulty label for small beginner-friendly PRs type:bug Bug fix work category bonus label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[#74] downloadFile revokes object URL immediately (broken on Safari)

2 participants