fix: delay object URL cleanup after downloads - #2313
Open
HitanshiThakar wants to merge 1 commit into
Open
Conversation
utksh1
approved these changes
Jul 30, 2026
utksh1
left a comment
Owner
There was a problem hiding this comment.
Focused Safari download fix with a deterministic timer regression test. The failed run contains the pre-existing saved-views baseline failure; main now passes. Approved once the branch is refreshed against current main so required checks rerun.
utksh1
force-pushed
the
fix/safari-download-object-url
branch
from
August 5, 2026 07:50
7c956b1 to
dae05d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Delays object URL cleanup in
downloadFileto avoid revoking the URL before downloads begin in Safari.Changes include:
URL.revokeObjectURL(url)by 1000ms aftera.click().Related Issues
Closes #1848
Type of Change
How Has This Been Tested?
Ran:
npm test -- exportUtils.test.ts
Checklist