test : added unit tests for ScanRateLimiter helpers in rate_limiter - #2328
Open
tmdeveloper007 wants to merge 1 commit into
Open
test : added unit tests for ScanRateLimiter helpers in rate_limiter#2328tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
Owner
|
Thanks for adding test coverage! This PR needs a rebase with main to pass CI. Please run: git fetch upstream
git rebase upstream/main
git push --force-with-leaseOnce rebased and CI passes, I'll merge immediately. |
Contributor
Author
|
Thanks! I have rebased the branch on the latest upstream/main and pushed. The PR should now be up to date. Please re-review when you have a chance. |
utksh1
approved these changes
Aug 4, 2026
utksh1
left a comment
Owner
There was a problem hiding this comment.
Reviewed the updated test submission. The coverage is focused and distinct from the duplicate PRs already closed. Backend scope is acceptable; merge remains subject to a current branch and the repository-required frontend security audit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added 17 unit tests for helper functions in
ScanRateLimiterfrombackend/secuscan/rate_limiter.py.Changes Made
testing/backend/unit/test_rate_limiter_scan_rate_limiter.pywith 17 tests_get_client_ip: proxy headers (X-Forwarded-For), direct clients, missing headers_build_error_response: formatting of 429 JSON responses, retry-after headers, X-Request-ID_check_burst_limit: burst window tracking, first-request initialization, limit enforcementImpact
All 17 tests pass. The rate limiter module had zero unit test coverage before this PR.
This task is being handled by tmdeveloper007 as part of the GSSOC Auto-PR cron.