test : added unit tests for _check_field helper in validation - #2342
Open
tmdeveloper007 wants to merge 1 commit into
Open
test : added unit tests for _check_field helper in validation#2342tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
Contributor
Author
|
Hi, this PR has been waiting for review for a few days now. All CI checks are green. Could you please take a look when you have a moment? Happy to make any adjustments if needed. |
utksh1
approved these changes
Aug 4, 2026
utksh1
left a comment
Owner
There was a problem hiding this comment.
Reviewed the focused test change and its current checks are green. The PR still needs a current branch update before merge because it is behind main; I will not bypass the branch policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2337.
Summary of What Has Been Done:
Added 20 unit tests for the
_check_fieldhelper function inbackend/secuscan/validation.py. This private function validates individual input field values against string length and array length limits, and is the core of thevalidate_task_start_payloadfunction.Changes Made:
testing/backend/unit/test_validation_check_field.pyImpact it Made:
Note: This task is being handled by tmdeveloper007 — please assign to that account when picking it up.