test : added unit tests for _gather_scan_summary in notification_service - #2428
Open
tmdeveloper007 wants to merge 1 commit into
Open
test : added unit tests for _gather_scan_summary in notification_service#2428tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
4 tasks
utksh1
approved these changes
Aug 4, 2026
utksh1
left a comment
Owner
There was a problem hiding this comment.
The code change is reviewed and the backend/lint checks are green. Merge remains blocked by the required frontend audit, which reports the pre-existing high-severity undici vulnerability; I am not bypassing that security gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2423.
Summary of What Has Been Done:
Created a new test file
testing/backend/unit/test_notification_service_gather_scan_summary.pywith 8 unit tests for the_gather_scan_summary()async helper inbackend/secuscan/notification_service.py.The function is exercised indirectly through
process_scan_completion_webhookbut not directly tested.Changes Made:
testing/backend/unit/test_notification_service_gather_scan_summary.pysetup_test_environmentfixture (to avoid loading FastAPI-dependent conftest)_seed_task_with_findingshelper for test data setupImpact it Made:
Note: This task is being handled by tmdeveloper007 — please assign to that account when picking it up.