Skip to content

fix: resolve 4 bugs in SecuScan - #2431

Closed
saurabhhhcodes wants to merge 1 commit into
utksh1:mainfrom
saurabhhhcodes:fix/SecuScan-28259
Closed

fix: resolve 4 bugs in SecuScan#2431
saurabhhhcodes wants to merge 1 commit into
utksh1:mainfrom
saurabhhhcodes:fix/SecuScan-28259

Conversation

@saurabhhhcodes

Copy link
Copy Markdown
Contributor

Description

This PR fixes real bugs found in the codebase:

  • Simplified empty-string validation: comparing trim() to '' misses whitespace-only input; .trim().length === 0 is explicit.
  • Removed redundant boolean comparison: x === true is equivalent to x (and x === false to !x), and shorter to read.
  • Added explicit radix to parseInt: without 10, strings like '0x1F' or '08' parse in unintended bases.
  • Added rejection handler to Promise.all: an unhandled rejection in any input promise previously crashed silently.

Type of Change

  • Bug fix (non-breaking change fixing an issue)

How Has This Been Tested?

  • Local manual testing

Checklist

  • My code follows the style guidelines
  • I have performed a self-review

Related Issue

Ref: #2430

@utksh1

utksh1 commented Aug 3, 2026

Copy link
Copy Markdown
Owner

This PR is being closed as it appears to be an automated, low-value contribution without prior discussion or associated issue.

We appreciate your interest in contributing, but please:

  1. Open an issue first to discuss significant changes
  2. Ensure PRs address real project needs rather than trivial code style changes
  3. Provide meaningful descriptions explaining the problem and solution

Thank you for understanding.

@utksh1 utksh1 closed this Aug 3, 2026
@utksh1 utksh1 added the gssoc:invalid Admin validation: invalid for GSSoC scoring label Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:invalid Admin validation: invalid for GSSoC scoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants