Skip to content

Fix Redis rate limiter TTL race condition #2463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tanishka-kuwar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Redis rate limiter TTL race condition #2463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions backend/secuscan/rate_limiter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,11 @@ async def check(self, request: Request) -> None:

pipe = self._redis.pipeline()
pipe.incr(minute_key)
pipe.expire(minute_key, self._rate_window * 2) # 2x TTL for safety
pipe.expire(
minute_key,
self._rate_window * 2,
nx=True,
) # Set TTL only if one does not already exist.
results = await pipe.execute()
minute_count = results[0]

Expand Down Expand Up @@ -218,7 +222,11 @@ async def check(self, request: Request) -> None:

pipe2 = self._redis.pipeline()
pipe2.incr(hour_key)
pipe2.expire(hour_key, self._burst_window * 2)
pipe2.expire(
hour_key,
self._burst_window * 2,
nx=True,
) # Set TTL only if one does not already exist.
results2 = await pipe2.execute()
hour_count = results2[0]

Expand Down
Loading