enh(api-gen): generate kdoc from api json #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedNaru
requested changes
Nov 7, 2023
| } | ||
| } | ||
|
|
||
| fun TypeSpec.Builder.addKdoc(documented: IDocumented): TypeSpec.Builder { |
There was a problem hiding this comment.
Those 3 types implement the Documentable interface, you can just define a generic extension <T: Documentable.Builder> for it instead of implementing 3 different ones.
| "method" | ||
| ) | ||
|
|
||
| private val tagsToSanitize = arrayOf( |
There was a problem hiding this comment.
I would also add handling of the [gdscript] [csharp] [codeblock] tags in the sanitizer.
chippmann
requested changes
Nov 8, 2023
kt/godot-library/src/main/kotlin/godot/gen/godot/AnimationNodeBlendTree.kt
Outdated
Show resolved
Hide resolved
kt/godot-library/src/main/kotlin/godot/gen/godot/AnimationNodeOneShot.kt
Outdated
Show resolved
Hide resolved
kt/godot-library/src/main/kotlin/godot/gen/godot/AnimationNodeOneShot.kt
Show resolved
Hide resolved
kt/godot-library/src/main/kotlin/godot/gen/godot/AudioStreamPlayer.kt
Outdated
Show resolved
Hide resolved
piiertho
force-pushed
the
enhancement/generate-doc-from-api-json
branch
2 times, most recently
from
2950ba7
to
f26a1bf
Compare
piiertho
force-pushed
the
chore/update-to-godot-4.2
branch
from
027ddb2
to
d27d079
Compare
piiertho
force-pushed
the
chore/update-to-godot-4.2
branch
from
d27d079
to
5c0fa25
Compare
piiertho
force-pushed
the
enhancement/generate-doc-from-api-json
branch
from
f26a1bf
to
3944552
Compare
chippmann
requested changes
Dec 27, 2023
| * sub-animation and return once it finishes. Blend times for fading in and out can be customized, as | ||
| * well as filters. | ||
| * After setting the request and changing the animation playback, the one-shot node automatically | ||
| * clears the request on the next process frame by setting its `request` value to [ONESHOTREQUESTNONE]. |
There was a problem hiding this comment.
ONESHOTREQUESTNONE something is off here. this should be ONE_SHOT_REQUEST_NONE
kt/godot-library/src/main/kotlin/godot/gen/godot/AnimationNodeOneShot.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes xml kdoc generation by using doc provided in api json.
To generate a new api use
--dump-extension-api-with-docsengine argument.