Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDKotlin Rework: Improve commandline, json and export. #608

Merged
merged 14 commits into from
Apr 26, 2024

Conversation

CedNaru
Copy link
Member

@CedNaru CedNaru commented Apr 14, 2024

Fix some issues with the previous configuration/command-line PR.

Regarding the export, I fixed the Linux issue, replaced all the strings with the same constants used in GDKotlin.
I also changed the JVM type exported for desktop. It doesn't use the same one as the editor anymore.
By default it uses the JVM, but you can add a export-graal-native-image feature to make it export graal instead.

@CedNaru CedNaru force-pushed the gd_kotlin/import_export_and_co branch 6 times, most recently from e09f7a1 to 0469b5b Compare April 15, 2024 04:03
@CedNaru CedNaru marked this pull request as ready for review April 15, 2024 04:14
@CedNaru CedNaru force-pushed the gd_kotlin/import_export_and_co branch from cdad1e0 to a5980ce Compare April 15, 2024 17:17
@CedNaru CedNaru force-pushed the gd_kotlin/import_export_and_co branch from 8e5ff25 to 839fbb9 Compare April 16, 2024 03:16
@CedNaru CedNaru requested a review from chippmann April 16, 2024 06:48
@CedNaru CedNaru force-pushed the gd_kotlin/import_export_and_co branch from 839fbb9 to b561986 Compare April 17, 2024 23:19
Base automatically changed from gd_kotlin/jvm_loading to gd_kotlin_rework April 23, 2024 14:22
@CedNaru CedNaru force-pushed the gd_kotlin/import_export_and_co branch from c514de1 to c173356 Compare April 23, 2024 16:14
@CedNaru CedNaru force-pushed the gd_kotlin/import_export_and_co branch from c173356 to 7e7e6e8 Compare April 26, 2024 10:13
@CedNaru CedNaru merged commit 4c7b151 into gd_kotlin_rework Apr 26, 2024
45 checks passed
@CedNaru CedNaru deleted the gd_kotlin/import_export_and_co branch April 26, 2024 11:46
CedNaru added a commit that referenced this pull request Apr 30, 2024
* Improve arguments for json and commandline
* Create version management for Json arguments.
* Set debug from command line if any debug argument used.
* Improve export
CedNaru added a commit that referenced this pull request May 7, 2024
* Improve arguments for json and commandline
* Create version management for Json arguments.
* Set debug from command line if any debug argument used.
* Improve export
CedNaru added a commit that referenced this pull request May 8, 2024
* Improve arguments for json and commandline
* Create version management for Json arguments.
* Set debug from command line if any debug argument used.
* Improve export
CedNaru added a commit that referenced this pull request May 9, 2024
* Improve arguments for json and commandline
* Create version management for Json arguments.
* Set debug from command line if any debug argument used.
* Improve export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants