-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDKotlin Rework: Improve commandline, json and export. #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedNaru
force-pushed
the
gd_kotlin/import_export_and_co
branch
6 times, most recently
from
April 15, 2024 04:03
e09f7a1
to
0469b5b
Compare
piiertho
force-pushed
the
gd_kotlin/jvm_loading
branch
from
April 15, 2024 17:05
045fc28
to
100b5d4
Compare
CedNaru
force-pushed
the
gd_kotlin/import_export_and_co
branch
from
April 15, 2024 17:17
cdad1e0
to
a5980ce
Compare
chippmann
reviewed
Apr 15, 2024
docs/src/doc/user-guide/advanced/commandline-args-and-configuration.md
Outdated
Show resolved
Hide resolved
CedNaru
force-pushed
the
gd_kotlin/import_export_and_co
branch
from
April 16, 2024 03:16
8e5ff25
to
839fbb9
Compare
chippmann
approved these changes
Apr 17, 2024
CedNaru
force-pushed
the
gd_kotlin/jvm_loading
branch
from
April 17, 2024 21:51
0ae8a0d
to
d80d24a
Compare
CedNaru
force-pushed
the
gd_kotlin/import_export_and_co
branch
from
April 17, 2024 23:19
839fbb9
to
b561986
Compare
CedNaru
force-pushed
the
gd_kotlin/import_export_and_co
branch
from
April 23, 2024 16:14
c514de1
to
c173356
Compare
piiertho
reviewed
Apr 26, 2024
CedNaru
force-pushed
the
gd_kotlin/import_export_and_co
branch
from
April 26, 2024 10:13
c173356
to
7e7e6e8
Compare
piiertho
approved these changes
Apr 26, 2024
CedNaru
added a commit
that referenced
this pull request
Apr 30, 2024
* Improve arguments for json and commandline * Create version management for Json arguments. * Set debug from command line if any debug argument used. * Improve export
CedNaru
added a commit
that referenced
this pull request
May 7, 2024
* Improve arguments for json and commandline * Create version management for Json arguments. * Set debug from command line if any debug argument used. * Improve export
CedNaru
added a commit
that referenced
this pull request
May 8, 2024
* Improve arguments for json and commandline * Create version management for Json arguments. * Set debug from command line if any debug argument used. * Improve export
CedNaru
added a commit
that referenced
this pull request
May 9, 2024
* Improve arguments for json and commandline * Create version management for Json arguments. * Set debug from command line if any debug argument used. * Improve export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some issues with the previous configuration/command-line PR.
Regarding the export, I fixed the Linux issue, replaced all the strings with the same constants used in GDKotlin.
I also changed the JVM type exported for desktop. It doesn't use the same one as the editor anymore.
By default it uses the JVM, but you can add a
export-graal-native-image
feature to make it export graal instead.