-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MemoryManager rework #661
MemoryManager rework #661
Conversation
9f498db
to
ce16e85
Compare
11a4124
to
8d7545b
Compare
f3a991d
to
860354b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work!
Will follow up with proper testing later this week
kt/godot-library/src/main/kotlin/godot/core/memory/MemoryManager.kt
Outdated
Show resolved
Hide resolved
kt/godot-library/src/main/kotlin/godot/core/memory/MemoryManager.kt
Outdated
Show resolved
Hide resolved
kt/api-generator/src/main/kotlin/godot/codegen/services/impl/GenerationService.kt
Show resolved
Hide resolved
caac52a
to
9f0b42b
Compare
- Remove forceGC argument.
Object are no longer put in ReferenceQueue
1d3e494
to
44faba4
Compare
kt/godot-library/src/main/kotlin/godot/core/memory/MemoryManager.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://godot-kotl.in/en/stable/contribution/knowledge-base/memory-management/
Should probably also be updated
3429346
to
333b4f6
Compare
333b4f6
to
5c9f30b
Compare
Solve #508, #618, #566, #666 and #617
It's honestly hard to explain in details all the changes without turning it into an essay. Most of the changes and explanations were already written in #618.
Here's a recap of the main changes: