Feature/implement new core types 4.3 #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedNaru
reviewed
Aug 21, 2024
piiertho
force-pushed
the
feature/implement-new-core-types-4.3
branch
from
f29cd8f
to
148da00
Compare
CedNaru
previously approved these changes
Aug 21, 2024
piiertho
force-pushed
the
feature/implement-new-core-types-4.3
branch
from
148da00
to
278d554
Compare
piiertho
force-pushed
the
feature/implement-new-core-types-4.3
branch
from
278d554
to
809c286
Compare
CedNaru
previously approved these changes
Aug 21, 2024
chippmann
requested changes
Aug 21, 2024
src/jvm_wrapper/memory/kt_binding.macos.editor.arm64-a1cb275f.o.tmp
Outdated
Show resolved
Hide resolved
src/jvm_wrapper/memory/long_string_queue.macos.editor.arm64-88fb0a13.o.tmp
Outdated
Show resolved
Hide resolved
src/jvm_wrapper/bridge/variant_array_bridge.macos.editor.arm64-31425541.o.tmp
Outdated
Show resolved
Hide resolved
src/jvm_wrapper/bridge/packed_int_64_array_bridge.macos.editor.arm64-cd375222.o.tmp
Outdated
Show resolved
Hide resolved
|
Tested for graalvm native-image on iOS. |
CedNaru
requested changes
Aug 26, 2024
chippmann
approved these changes
Aug 27, 2024
CedNaru
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
PackedVector4Array.This simplify packed arrays code using template and generics.
This needs test on android and graal.
Edit by @chippmann : Closes #646