Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we never added the new PackedVector4Array to the Variant.h.
So I just took the opportunity to rework the file a bit.
The function bodies are almost unchanged, only the general structure of the file changed. Instead of the KtVariant namespace, I have put all methods into the new
BufferToVariant
andVariantToBuffer
structures. Because everything is static, the structures act like a more fine-grained namespace. This is also how Godot does it through its codebase.Note that I also removed the initializer function for the array of function pointers. It's now done statically, no "if" is required during runtime anymore.
Before :
After: