-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from atty
to is-terminal
#4382
Migrate from atty
to is-terminal
#4382
Conversation
GNU testsuite comparison:
|
Nice! Seems like it created some duplicate dependencies. We have 3 ways of fixing that:
Could you check whether 1 or 2 are viable? And if not put the exceptions in |
Sure, I will check this. |
GNU testsuite comparison:
|
Cargo deny is still unhappy, could you please fix that? thanks |
Sorry for the delay, I'm from Brazil so we are having Carnival here. I will try to fix this today. |
Obrigado. it can wait until the end of the party :) |
I did check if 1 or 2 are viable and mostly because of I think that for now this isn't much of a problem because the best option would be to switch to the |
Alright, that's what we'll have to go with for now. Thanks for checking! We can do a little bit better if we also run Enjoy the festivities! |
GNU testsuite comparison:
|
Alright, we'll reduce the duplicate dependencies separately. Thanks! |
Closes #4377
I did this changes and run the whole test suits, it seems that anything broke.
I would also like to point out that
is_terminal
/IsTerminal
is currently on rust nigthly #98070 so maybe in the future would be great to change (again).