-
Notifications
You must be signed in to change notification settings - Fork 2
Cleanup #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This was a branch from the osx-64_support branch. It could be merged directly onto main. |
We should also consider preserving the tile row/col in the pipeline filenames. |
This reduces the number of readers to process from ~11600 to ~6900. Unfortunately, it means that the tile numbers are inconsistent with the pipeline numbers. Not a showstopper, but not ideal. I think a better approach here is to create the tile polygon index for the entire bbox, intersect with the user AOI, then store all of relevant metadata in the gdf for the tile, instead of creating and maintaining 4 additional lists for pointcloud_input_crs, readers, extents and original extents. Just return the GDF and expand elsewhere, instead of the lists. Keep the same tile ID. |
Testing with large geojson (~18000 km2), which involved 12278 tiles (2x2 km):
Several related issues require further attention, and some additional refactoring.