Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change secrets to dotenv based instead of config files #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change secrets to dotenv based instead of config files #140

wants to merge 1 commit into from

Conversation

e-wai
Copy link
Collaborator

@e-wai e-wai commented Aug 14, 2021

Just another way to storing secrets, do you like it better? It means we just send around the .env file to whoever needs it, and it would get placed as routemodel/data_retrieval/.env

@e-wai e-wai requested review from mdshiozaki and ufshk August 14, 2021 19:17
@e-wai
Copy link
Collaborator Author

e-wai commented Sep 9, 2021

One more comment - config is used elsewhere as a directory, and seems to conflict with virtualenv files: venv\lib\site-packages\config\__init__.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdshiozaki mdshiozaki Awaiting requested review from mdshiozaki

@ufshk ufshk Awaiting requested review from ufshk

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@e-wai