Skip to content

implement ResourceList component with agencies pages (DEV-77)#14

Open
ivymxu wants to merge 4 commits intomainfrom
feature/DEV-77/resourcelist
Open

implement ResourceList component with agencies pages (DEV-77)#14
ivymxu wants to merge 4 commits intomainfrom
feature/DEV-77/resourcelist

Conversation

@ivymxu
Copy link

@ivymxu ivymxu commented Feb 24, 2026

Jira ticket link

DEV-77

Implementation description

  • Add reusable ResourceList component with loading/empty/error states
  • Refactor /agencies page and add detail/edit pages
  • Create apiClient utility for typed API requests

Steps to test

  1. Navigate to http://localhost:3000/agencies
  2. Verify the table renders with columns: Name, Email, Phone, City, Status
  3. Test View action → /agencies/ shows agency details
  4. Test Edit action → /agencies//edit shows form with save functionality
  5. Test empty state by seeding no agencies
  6. Verify loading skeleton appears while data loads

What should reviewers focus on?

  • ResourceList component is generic and reusable
  • Column/action configuration is extensible for other resources (clients, donors, etc)
  • Cell rendering: email/phone are linkified, status badges are color-coded
  • Tests cover critical paths: rendering, loading, empty, error, actions
  • API client properly handles request/response interceptors
  • Error handling in detail/edit pages and form mutations

Checklist

Format for branch, commit, and PR title: docs/GIT.md.

  • My branch name includes the Jira ticket key
  • My PR name is descriptive and in imperative tense
  • My PR name includes the Jira ticket key
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • My commit messages include the Jira ticket key
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@ivymxu ivymxu force-pushed the feature/DEV-77/resourcelist branch from ea7e9ce to c27853f Compare February 27, 2026 01:00
@ivymxu ivymxu requested review from kenzysoror and sonya-q February 27, 2026 01:04
@ivymxu ivymxu force-pushed the feature/DEV-77/resourcelist branch from cbf380b to a117e60 Compare February 27, 2026 01:08
@ivymxu ivymxu marked this pull request as ready for review February 27, 2026 01:09
@nuthanan06 nuthanan06 assigned nuthanan06 and ivymxu and unassigned nuthanan06 Mar 6, 2026
@kenzysoror kenzysoror requested review from nuthanan06 and removed request for sonya-q March 6, 2026 13:22
Copy link
Contributor

@nuthanan06 nuthanan06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple changes on moving some things into other files + delete hasn't been implemented yet, otherwise lgtm! 🔥

</header>

<main className="flex-1 max-w-6xl mx-auto px-6 py-8 w-full">
<form onSubmit={handleSubmit} className="max-w-2xl space-y-6">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we edit the field, is it possible to autofill the fields with what the field has currently (like a get request to query)?

One problem I'm noticing when I test it is that if I don't add an email when I'm editing an agency, it will error out because it is mandatory in the request, may need to auto fill the fields just to prevent that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait just realized this might be DEV-76 that Brian is doing rn (@kenzysoror if you want to confirm that), might need to ignore this then 🔥

Copy link
Member

@kenzysoror kenzysoror Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup this is a really great point, and you're right about it being scoped within #26! i would say it's safe to ignore here :)

Copilot AI review requested due to automatic review settings March 10, 2026 00:17
@ivymxu ivymxu force-pushed the feature/DEV-77/resourcelist branch from a117e60 to 6e79ad6 Compare March 10, 2026 00:17

This comment was marked as resolved.

@ivymxu ivymxu force-pushed the feature/DEV-77/resourcelist branch from 6e79ad6 to 784e365 Compare March 10, 2026 00:23
@uwblueprint uwblueprint deleted a comment from Copilot AI Mar 10, 2026
@ivymxu ivymxu force-pushed the feature/DEV-77/resourcelist branch from 784e365 to d49f48b Compare March 10, 2026 00:46
@uwblueprint uwblueprint deleted a comment from Copilot AI Mar 10, 2026
@uwblueprint uwblueprint deleted a comment from Copilot AI Mar 10, 2026
@ivymxu ivymxu force-pushed the feature/DEV-77/resourcelist branch from 435bec2 to 1a294e2 Compare March 10, 2026 00:51
@uwblueprint uwblueprint deleted a comment from Copilot AI Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants