implement ResourceList component with agencies pages (DEV-77)#14
implement ResourceList component with agencies pages (DEV-77)#14
Conversation
ea7e9ce to
c27853f
Compare
cbf380b to
a117e60
Compare
nuthanan06
left a comment
There was a problem hiding this comment.
just a couple changes on moving some things into other files + delete hasn't been implemented yet, otherwise lgtm! 🔥
| </header> | ||
|
|
||
| <main className="flex-1 max-w-6xl mx-auto px-6 py-8 w-full"> | ||
| <form onSubmit={handleSubmit} className="max-w-2xl space-y-6"> |
There was a problem hiding this comment.
When we edit the field, is it possible to autofill the fields with what the field has currently (like a get request to query)?
One problem I'm noticing when I test it is that if I don't add an email when I'm editing an agency, it will error out because it is mandatory in the request, may need to auto fill the fields just to prevent that.
There was a problem hiding this comment.
wait just realized this might be DEV-76 that Brian is doing rn (@kenzysoror if you want to confirm that), might need to ignore this then 🔥
There was a problem hiding this comment.
yup this is a really great point, and you're right about it being scoped within #26! i would say it's safe to ignore here :)
a117e60 to
6e79ad6
Compare
6e79ad6 to
784e365
Compare
784e365 to
d49f48b
Compare
435bec2 to
1a294e2
Compare
Jira ticket link
DEV-77
Implementation description
Steps to test
What should reviewers focus on?
Checklist
Format for branch, commit, and PR title: docs/GIT.md.