Open
Conversation
124fd51 to
8f5cd1f
Compare
There was a problem hiding this comment.
Pull request overview
This PR implements full CRUD support for the Routes resource in the FastAPI backend and refactors Agencies to follow the same service-layer pattern, plus some minor import/formatting cleanups across the repo.
Changes:
- Implemented Routes CRUD endpoints and added a
route_servicebusiness-logic layer. - Refactored Agencies endpoints to use a new
agency_servicebusiness-logic layer with consistent error handling and empty-update validation. - Performed minor import ordering/formatting adjustments in backend modules and migrations.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/app/page.tsx | Removes an extraneous blank line in the home page layout. |
| backend/setup.py | Reorders setuptools imports. |
| backend/server.py | Adds a blank line between stdlib and third-party imports. |
| backend/migrations/versions/2adf14c14d9c_initial.py | Reorders imports in migration. |
| backend/migrations/versions/20260215_hafb_tables.py | Reorders imports in migration. |
| backend/migrations/versions/20260215_complete_schema_redesign.py | Reorders imports in migration. |
| backend/migrations/env.py | Adjusts import ordering for settings/models registration. |
| backend/app/services/routes.py | New: service layer implementing list/get/create/update/delete for routes incl. datetime normalization. |
| backend/app/services/agencies.py | New: service layer implementing CRUD operations for agencies incl. empty-update validation and IntegrityError handling. |
| backend/app/services/init.py | New: service package exports (agency_service, route_service). |
| backend/app/models/base.py | Import formatting changes only. |
| backend/app/models/init.py | Import formatting changes only. |
| backend/app/main.py | Import ordering cleanup. |
| backend/app/database.py | Import formatting cleanup. |
| backend/app/config.py | Import ordering cleanup. |
| backend/app/api/routes.py | Implements full CRUD endpoints for routes, delegating to route_service. |
| backend/app/api/agencies.py | Refactors endpoints to delegate to agency_service and adds consistent error handling / 204 response. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8f5cd1f to
365fb80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket link
Jira ticket
Implementation description
Steps to test
What should reviewers focus on?
Checklist
Format for branch, commit, and PR title: docs/GIT.md.