add CRUD operations for routes (DEV-58) by ivymxu · Pull Request #24 · uwblueprint/home-again

ivymxu · 2026-03-08T18:30:33Z

Jira ticket link

Jira ticket

Implementation description

Added CRUD for the Routes resource

Steps to test

Navigate to http://localhost:8000/docs
Create a route via POST /routes with a valid payload
List routes via GET /routes, confirm the new route appears
Get by ID via GET /routes/{route_id}, confirm 200 returned, try a fake ID and confirm 404
Update via PUT /routes/{route_id}, confirm fields update, submit an empty body {} and confirm 400
Delete via DELETE /routes/{route_id}, confirm 204, retry the same ID and confirm 404

What should reviewers focus on?

Empty update payload update_route / update_agency raise ValueError("No update fields were provided.") rather than silently no-oping
Datetime normalization in create_route], check that timezone-aware datetimes are converted to UTC and stripped before persistence

Checklist

Format for branch, commit, and PR title: docs/GIT.md.

My branch name includes the Jira ticket key
My PR name is descriptive and in imperative tense
My PR name includes the Jira ticket key
My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
My commit messages include the Jira ticket key
I have run the appropriate linter(s)
I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copilot

Pull request overview

This PR implements full CRUD support for the Routes resource in the FastAPI backend and refactors Agencies to follow the same service-layer pattern, plus some minor import/formatting cleanups across the repo.

Changes:

Implemented Routes CRUD endpoints and added a route_service business-logic layer.
Refactored Agencies endpoints to use a new agency_service business-logic layer with consistent error handling and empty-update validation.
Performed minor import ordering/formatting adjustments in backend modules and migrations.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
frontend/app/page.tsx	Removes an extraneous blank line in the home page layout.
backend/setup.py	Reorders setuptools imports.
backend/server.py	Adds a blank line between stdlib and third-party imports.
backend/migrations/versions/2adf14c14d9c_initial.py	Reorders imports in migration.
backend/migrations/versions/20260215_hafb_tables.py	Reorders imports in migration.
backend/migrations/versions/20260215_complete_schema_redesign.py	Reorders imports in migration.
backend/migrations/env.py	Adjusts import ordering for settings/models registration.
backend/app/services/routes.py	New: service layer implementing list/get/create/update/delete for routes incl. datetime normalization.
backend/app/services/agencies.py	New: service layer implementing CRUD operations for agencies incl. empty-update validation and IntegrityError handling.
backend/app/services/init.py	New: service package exports (`agency_service`, `route_service`).
backend/app/models/base.py	Import formatting changes only.
backend/app/models/init.py	Import formatting changes only.
backend/app/main.py	Import ordering cleanup.
backend/app/database.py	Import formatting cleanup.
backend/app/config.py	Import ordering cleanup.
backend/app/api/routes.py	Implements full CRUD endpoints for routes, delegating to `route_service`.
backend/app/api/agencies.py	Refactors endpoints to delegate to `agency_service` and adds consistent error handling / 204 response.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

backend/app/services/routes.py

backend/app/services/agencies.py

backend/app/api/routes.py

sonya-q · 2026-03-13T15:00:17Z

backend/app/api/routes.py

+            detail=str(e),
+        ) from e
+
+    return Response(status_code=status.HTTP_204_NO_CONTENT)


possibly redundant since FastAPI automatically sends 204 from the decorator

sonya-q · 2026-03-13T15:01:12Z

backend/app/api/routes.py

 """

-from fastapi import APIRouter, Response, status
+from fastapi import APIRouter, Depends, HTTPException, Response, status


also means Response can be removed from imports

sonya-q · 2026-03-13T15:06:53Z

backend/app/services/routes.py

+async def list_routes(db: AsyncSession) -> list[Route]:
+    """List all routes ordered by date."""
+    result = await db.execute(select(Route).order_by(Route.date))
+    return list(result.scalars().all())


Suggested change

return list(result.scalars().all())

return result.scalars().all()

result.scalars().all() already returns a list, so wrapping it in list may be redundant

sonya-q · 2026-03-13T15:09:44Z

backend/app/services/routes.py

+        await db.commit()
+    except IntegrityError as e:
+        await db.rollback()
+        logger.exception("IntegrityError creating route: %s", e.orig)


wowow IntegrityError super robust! 🙌

kenzysoror

awesome work, ivy!!🫡

remember to test all the endpoints one final time after merging main into the branch!

kenzysoror · 2026-03-14T05:47:40Z

backend/app/api/agencies.py

@@ -4,39 +4,39 @@
 Use this module as the reference pattern for other resources.


i think your agencies refactoring work might've been included in this PR! if that's what happened, i'd recommend reverting this file and deleting /services/agencies.py so this PR is only concerned with the routes CRUD

kenzysoror · 2026-03-14T05:48:36Z

backend/app/services/__init__.py

 Business logic layer; API routes depend on services, not the reverse.
 """

+from . import agencies as agency_service


Suggested change

from . import agencies as agency_service

once you decouple the agencies changes from the routes changes

kenzysoror · 2026-03-14T05:49:03Z

backend/app/services/__init__.py

 from . import donors as donor_service
 from . import clients as clients_service

+__all__ = ["agency_service", "route_service"]


Suggested change

__all__ = ["agency_service", "route_service"]

__all__ = ["route_service"]

once you decouple the agencies changes from the routes changes

kenzysoror · 2026-03-14T06:10:14Z

backend/app/services/routes.py

+from sqlalchemy.exc import IntegrityError
+from sqlalchemy.ext.asyncio import AsyncSession
+
+logger = logging.getLogger(__name__)


let's move this after the imports currently below it

Copilot AI review requested due to automatic review settings March 8, 2026 18:30

Copilot started reviewing on behalf of ivymxu March 8, 2026 18:30 View session

ivymxu force-pushed the feature/DEV-58/routes-crud branch from 124fd51 to 8f5cd1f Compare March 8, 2026 18:33

Copilot AI reviewed Mar 8, 2026

View reviewed changes

backend/app/services/routes.py Show resolved Hide resolved

backend/app/services/agencies.py Show resolved Hide resolved

backend/app/api/routes.py Show resolved Hide resolved

add CRUD operations for routes (DEV-58)

365fb80

ivymxu force-pushed the feature/DEV-58/routes-crud branch from 8f5cd1f to 365fb80 Compare March 8, 2026 19:11

Merge branch 'main' into feature/DEV-58/routes-crud

463647c

ivymxu marked this pull request as ready for review March 10, 2026 00:54

ivymxu requested a review from kenzysoror March 10, 2026 00:54

kenzysoror requested a review from sonya-q March 12, 2026 14:51

sonya-q requested changes Mar 13, 2026

View reviewed changes

kenzysoror requested changes Mar 14, 2026

View reviewed changes

	return list(result.scalars().all())
	return result.scalars().all()

		@@ -4,39 +4,39 @@
		Use this module as the reference pattern for other resources.

	__all__ = ["agency_service", "route_service"]
	__all__ = ["route_service"]

Conversation

ivymxu commented Mar 8, 2026 • edited by sonya-q Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jira ticket link

Implementation description

Steps to test

What should reviewers focus on?

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kenzysoror left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ivymxu commented Mar 8, 2026 •

edited by sonya-q

Loading

kenzysoror left a comment •

edited

Loading