[LLSC-32] Add script for starting up a postgres database with docker #10
+52
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayank808
approved these changes
Nov 21, 2024
backend/README.md
Outdated
| @@ -34,13 +34,19 @@ To start the backend locally, use the following command: | |||
| pdm run dev | |||
| ``` | |||
|
|
|||
| Note: If you wish to run the backend outside of Docker (e.g., for local development), you'll need to set up a PostgreSQL database. Ensure your database configuration is set properly in the environment variables before running the project. For the time being, the recommended approach for local development using the database is to use the docker compose Postgres instance with your local dev backend. | |||
| Note: If you wish to run the backend outside of Docker (e.g., for local development), you'll need to set up a PostgreSQL database. Ensure your database configuration is set properly in the environment variables before running the project. | |||
There was a problem hiding this comment.
add some note about setting up the readme properly prior to running this command
Mayank808
reviewed
Nov 21, 2024
| CMD pg_isready -U ${POSTGRES_USER} || exit 1 | ||
|
|
||
| # Expose PostgreSQL port | ||
| EXPOSE 5432 |
There was a problem hiding this comment.
Question when we run pdm run dev are we currently connecting to the right db port so that we automatically connect to the db when running locally?
There was a problem hiding this comment.
Yep 5432 is the current default db port.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Add postgres docker
Implementation description
Currently docker-compose is not convenient to iterate on, so it doesn't make sense to rely on it for a database. Instead, I've created a separate Dockerfile for testing the database during development.
Steps to test
pdm run dbdocker ps | grep llsc_db_dev_localto see if it's been started up.Checklist