[LLSC-53] Replace alembic migrate on startup with SQLAchemy create table #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Remove Alembic migration on startup
The
alembic.ini
andenv.py
config is taking control of the logging system when runningrun_migrations
usingalembic.command
llsc/backend/app/models/__init__.py
Line 14 in b74cc47
This is a bigger priority for productivity to maintain over worrying about up-to-date database migrations, so we need to remove the current system of making sure databases are up to date.
We will replace this with SQLAlchemy create table, which creates tables based on the models, not the migrations. We should conduct a further investigation of whether migration-based table management will be necessary.
Implementation description
Steps to test
pdm run dev
What should reviewers focus on?
Checklist